Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(example): remove obsolete fund_agents_if_low #582

Closed
wants to merge 1 commit into from

Conversation

Dacksus
Copy link
Contributor

@Dacksus Dacksus commented Nov 22, 2024

funds are added automatically on registration, no need to explicitly do this anymore.

@Dacksus Dacksus changed the title fix(examples): remove obsolete fund_agents_if_low fix(example): remove obsolete fund_agents_if_low Nov 22, 2024
@Dacksus Dacksus changed the title fix(example): remove obsolete fund_agents_if_low chore(example): remove obsolete fund_agents_if_low Nov 22, 2024
@Archento
Copy link
Member

Archento commented Dec 5, 2024

I think this is the only example where it actually makes sense to have the former (now redundant) function in. This is because we'll need to fund a separate wallet and not the agents' wallet itself during startup (to make sure the example works).
If there are no objections we can close this issue.

@Archento
Copy link
Member

Closing this now

@Archento Archento closed this Jan 13, 2025
@Archento Archento deleted the fix-obsolete-ex6 branch January 16, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants