Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): send address prefix to mailbox API #607

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

zmezei
Copy link
Contributor

@zmezei zmezei commented Jan 14, 2025

Proposed Changes

In Agentverse we want to show the address prefix ("agent" in case of mainnet agent, "test-agent" in case of testnet agent) prepended to the address everywhere where agents are listed/shown (for example agant://agent1qgd5jllcnav0u5dylemttag2cnmdewlpyhsjvy9z03kdr7xwyycyucfjf69 instead of agent1qgd5jllcnav0u5dylemttag2cnmdewlpyhsjvy9z03kdr7xwyycyucfjf69). For this the prefix needs to be sent to the mailbox API when a mailbox agent is created. This PR makes it possible to send the prefix.

Linked Issues

[if applicable, add links to issues resolved by this PR]

Types of changes

What type of change does this pull request make (put an x in the boxes that apply)?

  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Documentation update.
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

Put an x in the boxes that apply:

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

If applicable

  • I have added tests that prove my fix is effective or that my feature works
  • I have added/updated the documentation (executed the script in python/scripts/generate_api_docs.py)

Further comments

[if this is a relatively large or complex change, kick off a discussion by explaining why you chose the solution you did, what alternatives you considered, etc...]

@zmezei zmezei requested a review from qati January 14, 2025 12:53
Copy link
Contributor

@jrriehl jrriehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrriehl jrriehl merged commit a7fb7b0 into main Jan 14, 2025
11 checks passed
@jrriehl jrriehl deleted the feat/send_address_prefix_to_mailbox_api branch January 14, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants