Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix/#610] generator yaml에 datasource 설정이 잘 못된 문제 해결 #611

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

belljun3395
Copy link
Collaborator

@belljun3395 belljun3395 commented Mar 13, 2025

🎫 연관 이슈

resolved: #610

💁‍♂️ PR 내용

  • generator yaml에 datasource 설정이 잘 못된 문제 해결

🙏 작업

as-is
crm.generator. ...

to-be
generator

🙈 PR 참고 사항

📸 스크린샷

🚩 추가된 SQL 운영계 실행계획

🤖 테스트 체크리스트

  • 체크 미완료
  • 체크 완료

Summary by CodeRabbit

  • Chores
    • 애플리케이션 구성 파일 구조를 개선하여 데이터베이스 연결 설정이 보다 명확해졌습니다.
    • 스키마 관리 방식이 업데이트되어 운영 중 데이터베이스 스키마 변경을 원활하게 반영합니다.

Copy link

coderabbitai bot commented Mar 13, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

이번 변경은 application-generator-prd.yaml 구성 파일의 YAML 계층 구조를 재구성한 것입니다. 기존의 crm.generator 항목이 제거되고 상위 레벨에 generator 키가 도입되었으며, 그 하위에 데이터베이스 연결 정보를 포함하는 datasource 키가 추가되었습니다. 또한 JPA 설정에서 ddl-auto 값이 validate에서 update로 변경되었습니다. 제어 흐름 및 오류 처리 방식에는 영향을 주지 않습니다.

Changes

파일 변경 내용
domain/.../application-generator-prd.yaml - crm.generator 항목 제거
- 상위 레벨 generator 및 하위 datasource 추가 (데이터베이스 URL, username, password, driver-class-name 포함)
- ddl-auto 설정: validateupdate

Poem

깡총깡총 뛰는 작은 토끼,
코드 숲 속에 빛을 피우네.
crm은 이젠 안녕,
generator가 길을 열었네.
스키마 춤추는 데이터의 밤,
나의 발자국 따라 즐겁게! 🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 02cc2e9 and 7db129f.

📒 Files selected for processing (1)
  • domain/generator/src/main/resources/application-generator-prd.yaml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the fix label Mar 13, 2025
@belljun3395 belljun3395 merged commit fceba2e into dev Mar 13, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generator yaml에 datasource 설정이 잘 못된 문제 해결
1 participant