Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #71

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Refactoring #71

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
52928be
prepare changelog
fewieden Feb 13, 2021
df8a622
switching to v4 due to empty tables in v2 of the API
fewieden Feb 13, 2024
8adf20a
adjust tests to API v4
fewieden Feb 13, 2024
75f093f
Update package.json
fewieden Feb 13, 2024
8562a3f
Removes dependency node-fetch
fewieden Feb 13, 2024
12e2e96
Update package-lock.json
fewieden Feb 13, 2024
85fe4c2
Removes TravisCI configuration
fewieden Feb 13, 2024
05c7c8e
Upgrades jest
fewieden Feb 17, 2024
e64f44f
Updates tests
fewieden Feb 18, 2024
8066487
Updates tests
fewieden Feb 18, 2024
f37fa9c
Update API response mock
fewieden Feb 18, 2024
213550e
Update GitHub actions
fewieden Feb 18, 2024
e5ab0b3
Updates reference to new GitHub repository of MagicMirror² project
fewieden Mar 3, 2024
b1e0640
Adds category sport for 3rd party module list
fewieden Mar 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [ 14.x ]
node-version: [ 21.x ]
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm ci
Expand All @@ -27,12 +27,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [10.x, 12.x, 14.x]
node-version: [18.x, 20.x, 21.x]
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm ci
- run: npm run test
- run: npm test
3 changes: 1 addition & 2 deletions .github/workflows/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ jobs:
check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: dangoslen/[email protected]
- uses: dangoslen/changelog-enforcer@v3
with:
changeLogPath: CHANGELOG.md
skipLabels: Skip Changelog
6 changes: 3 additions & 3 deletions .github/workflows/coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ jobs:
upload-coverage-report:
strategy:
matrix:
node-version: [ 14.x ]
node-version: [ 21.x ]
platform: [ ubuntu-latest ]
runs-on: ${{ matrix.platform }}
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm ci
Expand Down
11 changes: 0 additions & 11 deletions .travis.yml
View file
Open in desktop

This file was deleted.

22 changes: 22 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,27 @@
# MMM-soccer Changelog

## [Unreleased]

**Requires version >= 18 of NodeJS!**

### Fixed

* [Switching to v4 due to empty tables in v2 of the API](https://github.com/fewieden/MMM-soccer/issues/70)

### Added

* 100% test coverage requirement

### Changed

* Use `logger` instead of `console`
* Updated dependencies

### Removed

* Dependency [node-fetch](https://www.npmjs.com/package/node-fetch)
* TravisCI configuration

## [2.2.1]

### Fixed
Expand Down
2 changes: 0 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ European Soccer Standings Module for MagicMirror²

* An installation of [MagicMirror²](https://github.com/MichMich/MagicMirror)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the URL to https://github.com/MagicMirrorOrg/MagicMirror.

* OPTIONAL: [Voice Control](https://github.com/fewieden/MMM-voice) and [MMM-Modal](https://github.com/fewieden/MMM-Modal)
* npm
* [node-fetch](https://www.npmjs.com/package/node-fetch)

## Installation

Expand Down
14 changes: 0 additions & 14 deletions __mocks__/console.js
View file
Open in desktop

This file was deleted.

8 changes: 6 additions & 2 deletions __mocks__/Logger.js → __mocks__/logger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
global.Log = {
const logger = {
debug: jest.fn(),
log: jest.fn(),
info: jest.fn(),
warn: jest.fn(),
error: jest.fn(),
}
};

global.Log = logger;

module.exports = logger;
Loading
Loading