-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Nested states (compound / parallel) and support for SCXML (test suit) #501
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #501 +/- ##
===========================================
- Coverage 100.00% 96.21% -3.79%
===========================================
Files 25 31 +6
Lines 1631 3227 +1596
Branches 257 466 +209
===========================================
+ Hits 1631 3105 +1474
- Misses 0 71 +71
- Partials 0 51 +51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ecc7957
to
1b74bf5
Compare
5ce640e
to
7efb429
Compare
…hen entering a top level final state the SM terminates
…for TypedDict and | operator
f1edb7f
to
1e7f40d
Compare
…ons for executable content
37669ac
to
dbac19b
Compare
8030a84
to
8c340c4
Compare
0890680
to
35f4bed
Compare
e2b6907
to
b392cbd
Compare
…es parameter since scxml don't expect that the graph should have a single component
…tance should keep the same
Quality Gate failedFailed conditions |
Is this in a state (🤣) that I could try it out? I have several use-cases where the sub-state functionality would be useful and I'd be glad to give feedback if I run into issues. Note, the user experience I had expected looked something like this: class SubMachine(StateMachine):
test = State(initial=True)
test_complete = State(final=True)
next = test.to(test_complete)
class TestSM(StateMachine):
initial_state = State(initial=True)
sub_machine_as_state = SubMachine()
some_other_state = State(final=True)
goto_sub_machine = initial_state.to(sub_machine_as_state)
goto_finish = sub_machine_as_state.to(some_other_state) And then something like sm = TestSM()
sm.send('goto_sub_machine')
sm.send('next') # TestSM now has the submachine states as states it can traverse.
sm.send('goto_finish') |
Another approach for #329.
By supporting the test cases defined at https://www.w3.org/Voice/2013/scxml-irp/ we can incorporate small functionalities until we get covered by the full spec.