Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeQL workflow #87

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add CodeQL workflow #87

wants to merge 2 commits into from

Conversation

HumzahJavid
Copy link
Collaborator

Closes #86

Description

This PR will:

  • Add a CodeQL workflow file

@HumzahJavid HumzahJavid self-assigned this Sep 19, 2024
Copy link
Member

@Pasarus Pasarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we remove most of the comments? largely seems to be an exercise of check this, do that, etc, then delete.

In response to PR comments
Copy link
Member

@Pasarus Pasarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a thought. Are we not doing the harden-runner already?

- name: Harden Runner

@HumzahJavid
Copy link
Collaborator Author

Yes, you're right however the hardened runner has a workflow level scope rather than the entire suite of workflows.

The following two outputs are different:
https://app.stepsecurity.io/github/fiaisis/admin-portal/actions/runs/10942169442?jobid=30378528092&tab=network-events
https://app.stepsecurity.io/github/fiaisis/admin-portal/actions/runs/10941294119?jobid=30375605887&tab=network-events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing CodeQL analysis
2 participants