Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jwt auth #12

Merged
merged 47 commits into from
Jun 13, 2024
Merged

Add jwt auth #12

merged 47 commits into from
Jun 13, 2024

Conversation

keiranjprice101
Copy link
Collaborator

@keiranjprice101 keiranjprice101 commented Jun 10, 2024

Description

This adds the JWT authentication mechanism it also replaces pylint and black with ruff.

It does not completely implement the role based access, due to a database migration being required. But that is covered in issue #13

Copy link

codecov bot commented Jun 10, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@keiranjprice101 keiranjprice101 marked this pull request as ready for review June 12, 2024 08:21
Copy link
Member

@Pasarus Pasarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions and suggestions from first pass code review

.github/workflows/linting.yml Outdated Show resolved Hide resolved
.github/workflows/linting.yml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
src/tokens.py Outdated Show resolved Hide resolved
test/e2e/test_experiments.py Outdated Show resolved Hide resolved
test/e2e/test_experiments.py Outdated Show resolved Hide resolved
test/e2e/test_experiments.py Outdated Show resolved Hide resolved
test/e2e/test_experiments.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@Pasarus Pasarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes to facilitate using the HTTPStatus enum

test/e2e/test_auth.py Outdated Show resolved Hide resolved
test/e2e/test_auth.py Outdated Show resolved Hide resolved
test/e2e/test_auth.py Outdated Show resolved Hide resolved
test/e2e/test_auth.py Outdated Show resolved Hide resolved
test/e2e/test_auth.py Outdated Show resolved Hide resolved
test/e2e/test_auth.py Outdated Show resolved Hide resolved
test/e2e/test_auth.py Outdated Show resolved Hide resolved
test/test_auth.py Outdated Show resolved Hide resolved
test/test_auth.py Outdated Show resolved Hide resolved
test/test_auth.py Outdated Show resolved Hide resolved
keiranjprice101 and others added 2 commits June 13, 2024 11:40
Co-authored-by: Samuel Jones <[email protected]>
Co-authored-by: Samuel Jones <[email protected]>
@Pasarus Pasarus merged commit ec78bb1 into main Jun 13, 2024
8 checks passed
@Pasarus Pasarus deleted the add_jwt_auth branch June 13, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants