Add Interactive Reduction logo and fix light / dark mode bug #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is way staging and prod can be different and we can also just change it for whatever we need during development.
Add accessibility changes to table
Avoids issues when running the app through SciGateway
Some headings currently have placeholder values until the API functionality is added
Fixes bug where pages weren't re-rendering elements when switching between pages
Removes incompatible tags
Made the text and logo much more legible
Pasarus
approved these changes
Mar 1, 2024
Dagonite
added a commit
that referenced
this pull request
Mar 6, 2024
commit 6de3801 Author: Samuel <[email protected]> Date: Wed Mar 6 09:59:00 2024 +0000 Add logo design file (#55) commit 6df5887 Author: Samuel <[email protected]> Date: Wed Mar 6 09:58:39 2024 +0000 Make plugin url an environment variable (#54) * Move plugin url into environment var * Update explanation comment commit 0f401c0 Author: Samuel <[email protected]> Date: Tue Mar 5 09:03:13 2024 +0000 Add initial Cypress tests (#38) * Update route names * Update reduction history page * Remove commented out code * Remove redundant comments * Allow a more dynamic selection of the IR-API IP using an env file, this way staging and prod can be different and we can also just change it for whatever we need during development. * Alter fetch request logic Add accessibility changes to table * Update reduction history button url * Correct route for SciGateway sidebar * Alter homepage browse reductions url * Add missing new line * Use different port Avoids issues when running the app through SciGateway * Add missing table headings Some headings currently have placeholder values until the API functionality is added * Fix url * Make even rows background color use theme * Delete History.tsx * Sort by desc initially so recent reductions at the top * Correct wrong run date being rendered * Add initial cypress tests * Disable failed test * Comment out broken up code * Update TODO comment * Remove duplicate route * Update yarn.lock Accounts for missing dependencies * Delete cypress/fixtures/example.json * Remove false test --------- Co-authored-by: Samuel Jones <[email protected]> Co-authored-by: Samuel Jones <[email protected]> commit 327f7ce Author: Samuel <[email protected]> Date: Fri Mar 1 13:14:40 2024 +0000 Add Interactive Reduction logo and fix light / dark mode bug (#43) * Update route names * Update reduction history page * Remove commented out code * Remove redundant comments * Allow a more dynamic selection of the IR-API IP using an env file, this way staging and prod can be different and we can also just change it for whatever we need during development. * Alter fetch request logic Add accessibility changes to table * Update reduction history button url * Correct route for SciGateway sidebar * Alter homepage browse reductions url * Add missing new line * Use different port Avoids issues when running the app through SciGateway * Add missing table headings Some headings currently have placeholder values until the API functionality is added * Fix url * Make even rows background color use theme * Delete History.tsx * Sort by desc initially so recent reductions at the top * Correct wrong run date being rendered * Add svg logos * Add wordless logos * Update favicon.ico * Move theme out of component Fixes bug where pages weren't re-rendering elements when switching between pages * Minify svg Removes incompatible tags * Add IR logo to top of web app * Use more appropriate file names * Use updated logo design Made the text and logo much more legible --------- Co-authored-by: Samuel Jones <[email protected]> Co-authored-by: Samuel Jones <[email protected]> commit a1865b3 Author: Samuel <[email protected]> Date: Thu Feb 29 15:01:43 2024 +0000 Add reduction history page to display runs (#36) * Update route names * Update reduction history page * Remove commented out code * Remove redundant comments * Allow a more dynamic selection of the IR-API IP using an env file, this way staging and prod can be different and we can also just change it for whatever we need during development. * Alter fetch request logic Add accessibility changes to table * Update reduction history button url * Correct route for SciGateway sidebar * Alter homepage browse reductions url * Add missing new line * Use different port Avoids issues when running the app through SciGateway * Add missing table headings Some headings currently have placeholder values until the API functionality is added * Fix url * Make even rows background color use theme * Delete History.tsx * Sort by desc initially so recent reductions at the top * Correct wrong run date being rendered * Increase prettier line length * Refactor to accommodate api changes * Adding missing sorting functionality * Change any type * Prettier formatting changes * Remove debugging logs * Add reduction status formatting * Add missing sorting functionality --------- Co-authored-by: Samuel Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28, closes #27.
Description
Fixes issues relating to compenents not properly rendering colours based on the currently applied theme from SciGateway. Also adds in the new logo at the top.