Cull pylint and format better

fiaisis · Jun 11, 2024 · 836d098 · 836d098
1 parent 1cae1d1
commit 836d098
Show file tree

Hide file tree

Showing 8 changed files with 0 additions and 636 deletions.
diff --git a/.pylintrc b/.pylintrc
diff --git a/rundetection/job_requests.py b/rundetection/job_requests.py
@@ -12,7 +12,6 @@
 
 
 # splitting this class would be worse than this disable
-# pylint: disable = too-many-instance-attributes
 @dataclasses.dataclass
 class JobRequest:
     """

diff --git a/rundetection/rules/mari_rules.py b/rundetection/rules/mari_rules.py
@@ -56,7 +56,6 @@ def verify(self, job_request: JobRequest) -> None:
         run_numbers = self._get_runs_to_stitch(
             job_request.filepath, job_request.run_number, job_request.experiment_title
         )
-        # pylint: disable = duplicate-code
         if len(run_numbers) > 1:
             additional_request = deepcopy(job_request)
             additional_request.additional_values["runno"] = run_numbers
@@ -66,7 +65,6 @@ def verify(self, job_request: JobRequest) -> None:
             additional_request.additional_values["mask_file_link"] = self._spec_values["marimaskfile"]
             additional_request.additional_values["wbvan"] = self._spec_values["mariwbvan"]
             job_request.additional_requests.append(additional_request)
-        # pylint: enable = duplicate-code
 
 
 class MariMaskFileRule(Rule[str]):

diff --git a/rundetection/rules/osiris_rules.py b/rundetection/rules/osiris_rules.py
@@ -80,7 +80,6 @@ def _is_diff_phase(self, phase10: float, phase6: float) -> bool:
                 return True
         return False
 
-    # pylint: disable=too-many-arguments
     def _determine_mode(
         self, phase10: float, phase6: float, freq: int, detector_tcb_min: float, detector_tcb_max: float
     ) -> Literal["diffraction"] | Literal["spectroscopy"]:
@@ -106,7 +105,6 @@ def _determine_mode(
 
         return "diffraction" if is_diff_phases else "spectroscopy"
 
-    # pylint: enable=too-many-arguments
     def verify(self, job_request: JobRequest) -> None:
         if not self._value:
             return
@@ -235,7 +233,6 @@ def verify(self, job_request: JobRequest) -> None:
                 return
         except KeyError:
             pass
-        # pylint: disable = duplicate-code
         # stitch
         job_request.additional_values["input_runs"] = [job_request.run_number]
         run_numbers = self._get_runs_to_stitch(
@@ -246,7 +243,6 @@ def verify(self, job_request: JobRequest) -> None:
             additional_request = deepcopy(job_request)
             additional_request.additional_values["input_runs"] = run_numbers
             job_request.additional_requests.append(additional_request)
-        # pylint: enable = duplicate-code
 
 
 class OsirisCalibrationRule(Rule[str]):

diff --git a/rundetection/rules/tosca_rules.py b/rundetection/rules/tosca_rules.py
@@ -45,7 +45,6 @@ def verify(self, job_request: JobRequest) -> None:
         if not self._value:  # if the stitch rule is set to false, skip
             return
 
-        # pylint: disable = duplicate-code
         job_request.additional_values["input_runs"] = [job_request.run_number]
         run_numbers = self._get_runs_to_stitch(
             job_request.filepath, job_request.run_number, job_request.experiment_title
@@ -55,4 +54,3 @@ def verify(self, job_request: JobRequest) -> None:
             additional_request = deepcopy(job_request)
             additional_request.additional_values["input_runs"] = run_numbers
             job_request.additional_requests.append(additional_request)
-        # pylint: enable = duplicate-code
diff --git a/test/rules/test_common_rules.py b/test/rules/test_common_rules.py
@@ -2,7 +2,6 @@
 Unit tests for common rules
 """
 
-# pylint: disable=redefined-outer-name
 import unittest
 from pathlib import Path
 

diff --git a/test/rules/test_mari_rules.py b/test/rules/test_mari_rules.py
@@ -4,8 +4,6 @@
 
 import json
 import os
-
-# pylint:disable = redefined-outer-name, protected-access
 from pathlib import Path
 from typing import Any
 from unittest.mock import patch

diff --git a/test/test_specifications.py b/test/test_specifications.py
@@ -4,8 +4,6 @@
 
 import os
 from pathlib import Path
-
-# pylint: disable=protected-access, redefined-outer-name
 from unittest.mock import Mock, patch
 
 import pytest