Get specification via fia-api #307
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should've been removed in #306
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
=======================================
Coverage 94.69% 94.69%
=======================================
Files 13 13
Lines 565 565
=======================================
Hits 535 535
Misses 30 30 ☔ View full report in Codecov by Sentry. |
…compose action, start using requests to fia_api To start adding fia-api container to running of docker container
HumzahJavid
force-pushed
the
use-fia-api-get-specifications
branch
from
d0c2351
to
34c8492
Compare
…se for run-detection
FIA_API can communicate with the DB but not rundetection
… load_rules, fix healthcheck fia-api service, To make the run-detection container run without crashing. Related commits in fia-api #384 622f24b599d1f6a113dbbe9dbc3b2fef1eaf8dfe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #291
Description
This PR will:
specification_generator.py(This should've been removed in PR Move JSON specification files to the DB #306)