Apply changes from PR #82 to the develop [default] branch (aid on solution for fibercrypto/skywallet-mcu#342) #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e protob.exe target
…move the protoc binary
|
@olemis This PR is ready to merge |
stdevPavelmc
added
bug
olemis
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83 changes was wrongly applied to master when the default branch is develop, develop is the one used on fibercrypto/skywallet-mcu and this will aid to fix fibercrypto/skywallet-mcu#342
Changes:
Does this change need to mentioned in CHANGELOG.md?
No
Related issues:
PR fibercrypto/skywallet-mcu#342
PR #81