Converters for Corsica and Kenya #52
Conversation
| @@ -0,0 +1,139 @@ | |||
| # TEMPLATE FOR A FIBOA CONVERTER | |||
There was a problem hiding this comment.
I'd propose to rename the file to fs_fr_cor for consistency.
| @@ -0,0 +1,138 @@ | |||
| # TEMPLATE FOR A FIBOA CONVERTER | |||
There was a problem hiding this comment.
I'd propose to rename the file to fs_ke for consistency.
There was a problem hiding this comment.
Not sure about this. Since in the meeting We (Hannah, Jacob, Me and Snehal) decided to keep a naming convention similar to boundaries__.parquet to keep it a bit separate than the rest of the global dataset. We can discuss more on this I feel.
There was a problem hiding this comment.
This is just the converter name, not the output file name?! Anyway, I'm fine if it's consistent. I this case the other PRs should also align.
There was a problem hiding this comment.
Yes okay, I will cross check to make sure all the fieldscape PRs align.
| # Add columns with constant values. | ||
| # The key is the column name, the value is a constant value that's used for all rows. | ||
| ADD_COLUMNS = { | ||
| "determination_datetime": "2021-01-01T00:00:00Z" |
There was a problem hiding this comment.
2022 (as in the file name) and 2021 (as determination datetime) doesn't quite fit together.
There was a problem hiding this comment.
Right this is slight mistake.
| # Title of the collection | ||
| TITLE = "Field boundaries for Kenya (Fieldscapes)" | ||
| # Description of the collection. Can be multiline and include CommonMark. | ||
| DESCRIPTION = """ The dataset contains field boundaries for the Kenya.""" |
There was a problem hiding this comment.
| DESCRIPTION = """ The dataset contains field boundaries for the Kenya.""" | |
| DESCRIPTION = "The dataset contains field boundaries for the Kenya." |
|
|
||
| # Schemas for the fields that are not defined in fiboa | ||
| # Keys must be the values from the COLUMNS dict, not the keys | ||
| MISSING_SCHEMAS = { |
There was a problem hiding this comment.
Schema for crop_name is missing.
| # Title of the collection | ||
| TITLE = "Field boundaries for Corsica (Fieldscapes)" | ||
| # Description of the collection. Can be multiline and include CommonMark. | ||
| DESCRIPTION = """ The dataset contains field boundaries for the Corsica.""" |
There was a problem hiding this comment.
| DESCRIPTION = """ The dataset contains field boundaries for the Corsica.""" | |
| DESCRIPTION = "The dataset contains field boundaries for the Corsica." |
| # Provider name, can be None if not applicable, must be provided if PROVIDER_URL is provided | ||
| PROVIDER_NAME = "Republique Francaise - Geoservices" | ||
| # URL to the homepage of the data or the provider, can be None if not applicable | ||
| PROVIDER_URL = "https://data.geopf.fr/telechargement/download/RPG/RPG_2-0__SHP_LAMB93_R94_2022-01-01/RPG_2-0__SHP_LAMB93_R94_2022-01-01.7z.001" |
There was a problem hiding this comment.
Did you run this? I don't think we have 7zip support yet. Related to #50
There was a problem hiding this comment.
Yes, it has to be downloaded and dun on the gpkg inside.
There was a problem hiding this comment.
We have 7z support now, no manuals steps required.
There was a problem hiding this comment.
No there were manual steps involved like creating a subset of the original dataset, Not all the fieldscapes datasets cover the entire original data sources. Hence, this step.
| # Keys must be the values from the COLUMNS dict, not the keys | ||
| MISSING_SCHEMAS = { | ||
| "required": [], # i.e. non-nullable properties | ||
| "properties": { |
There was a problem hiding this comment.
schemas mssing for crop_name and crop_id
There was a problem hiding this comment.
Do we have to do this for all the countries?
There was a problem hiding this comment.
If there's no extension, yes. That's why I recommended an extension.
|
Please rebase the PR to the latest CLI version, including renaming the URI constant to SOURCES and renaming the parameter cache_file to cache. I tried to push it upstream, but you didn't permit changes to this PR so you need to do these changes yourself. Thanks. |
|
Yes rebased the fork with the latest cli, Will update these comments in the latest PR pushes. |
No description provided.