Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

page.py:20-22: Implement Breadcrumbs class. Use it... #345

Closed
0pdd opened this issue Sep 20, 2019 · 1 comment · Fixed by #346
Closed

page.py:20-22: Implement Breadcrumbs class. Use it... #345

0pdd opened this issue Sep 20, 2019 · 1 comment · Fixed by #346
Assignees
@duker33
Labels
1 hour typical issue size. It's one pdd hour. Performer should spend about one astronomical hour for this i 1 burning issue cleanup everything that do project stronger, flexible, reusable

Comments

@0pdd
Copy link
Collaborator

0pdd commented Sep 20, 2019

The puzzle 343-4255fdd0 from #343 has to be resolved:

refarm-site/pages/logic/page.py

Lines 20 to 22 in 202424c

# @todo #343:60m Implement Breadcrumbs class.
# Use it instead of monolithic logic at the `breadcrumbs_with_siblings`.
# Create Breadcrumb class or named tuple to specify crumb data structure.

The puzzle was created by duker33 on 20-Sep-19.

Estimate: 60 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Sep 20, 2019
@duker33
#343 Fix siblings logic. Refactor Breadcrumbs arch (#344)
202424c 
* #343  Drop redundant logic from siblings fetching. High level arch for breadcrumbs

* #343  Trigger CI
@0pdd 0pdd mentioned this issue Sep 20, 2019
Closed
@duker33 duker33 self-assigned this Sep 20, 2019
@duker33 duker33 added 1 burning issue 1 hour typical issue size. It's one pdd hour. Performer should spend about one astronomical hour for this i cleanup everything that do project stronger, flexible, reusable labels Sep 20, 2019
duker33 added a commit that referenced this issue Sep 20, 2019
@duker33
#345 Simplify breadcrumbs logic
bd2d8b1
duker33 added a commit that referenced this issue Sep 20, 2019
@duker33
#345 Rm model.Page.get_index method
8885299
duker33 added a commit that referenced this issue Sep 20, 2019
@duker33
#345 Implement breadcrumbs functions
5e3bbe6
@duker33 duker33 mentioned this issue Sep 20, 2019
Merged
duker33 added a commit that referenced this issue Sep 21, 2019
@duker33
#345 Rm redundant "select_related" field
bc4dcc4
duker33 added a commit that referenced this issue Sep 22, 2019
@duker33
#345 Minor logic fixes
e344ca4
duker33 added a commit that referenced this issue Sep 23, 2019
@duker33
#345 Review#1 fix. Create two public methods instead of one with conf…
3f0333c 
…iguration
duker33 added a commit that referenced this issue Sep 23, 2019
@duker33
#345 Implement crumbs (#346)
6350027 
* #345  Simplify breadcrumbs logic

* #345  Rm model.Page.get_index method

* #345  Implement breadcrumbs functions

* #345  Rm redundant "select_related" field

* #345  Minor logic fixes

* #345  Review#1 fix. Create two public methods instead of one with configuration
This was referenced Sep 23, 2019
Open
Open
@0pdd
Copy link
Collaborator Author

0pdd commented Sep 23, 2019

@0pdd 2 puzzles #347, #348 are still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duker33 duker33

Labels
1 hour typical issue size. It's one pdd hour. Performer should spend about one astronomical hour for this i 1 burning issue cleanup everything that do project stronger, flexible, reusable
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#345 Implement crumbs fidals/refarm-site
2 participants
@duker33 @0pdd