#345 Implement crumbs #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemijRodionov
approved these changes
Sep 23, 2019
pages/templatetags/pages_extras.py
Outdated
| (page.display_menu_title, '', logic.Page(page).siblings) | ||
| ] | ||
|
|
||
| def breadcrumbs(page: Page, separator='', show_siblings=False): |
There was a problem hiding this comment.
I believe it would be much better to get rid this cryptic show_siblings and create two separate functions breadcrumbs and breadcrumbs_with_siblings
duker33
commented
Sep 30, 2023
| <span class="breadcrumbs-separator">{{ separator }}</span> | ||
| {% endif %} | ||
| </span> | ||
| {% for logic_page in breadcrumbs %} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #345
Kick out Breadcrumbs class because of pretty small set of real breadcrumbs code.
Implemented all it's functions inside
logic.Page.breadcrumbsmethod