Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup pre-commit hook to lint the files before comitting #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Andras-Simon
Copy link

@Andras-Simon Andras-Simon commented Oct 16, 2019

Since the .git folder is not versioned I created the .githooks folder, where the pre-commit script resides.

I created a setup-pre-commit-linting npm script, which simply sets the git hooks directory to .githooks. This will be automatically executed after npm install. #15

Since the .git folder is not versioned I created the .githooks folder, where the pre-commit script resides.

I created a setup-pre-commit-linting npm script, which simply sets the git hooks directory to .githooks. This will be automatically executed after npm install.
@JayaKrishnaNamburu
Copy link
Collaborator

Hi @Andras-Simon thanks for the PR, currently it is not running npm run lint. Am I missing something, please let me know 😃

@JayaKrishnaNamburu JayaKrishnaNamburu self-requested a review October 16, 2019 16:42
@Andras-Simon
Copy link
Author

Hi @JayaKrishnaNamburu ,

if you run npm install it will set up the hook for you.
You can also use npm run setup-pre-commit-linting if you already ran npm install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants