Implemented Validation check for Serial Number and DeviceInfo #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adarshan-intel
commented
Oct 9, 2023
•
adarshan-intel
commented
- Implemented Validation check for device serial Number and DeviceInfo
- Created Unit Test to validate the function on different possible strings ( All tests passing )
adarshan-intel
changed the title
DukeDavis12
reviewed
Oct 25, 2023
protocol/src/test/java/org/fidoalliance/fdo/protocol/ManufacturingInfoTest.java
Outdated
Show resolved
Hide resolved
DukeDavis12
reviewed
Oct 25, 2023
...src/main/java/org/fidoalliance/fdo/protocol/serialization/ManufacturingInfoDeserializer.java
Show resolved
Hide resolved
Signed-off-by: Adarsh Anand <[email protected]>
adarshan-intel
force-pushed
the
fuzzing_fixes_DI_10
branch
from
2b0adfc
to
193ccdc
Compare
DukeDavis12
reviewed
Oct 27, 2023
...src/main/java/org/fidoalliance/fdo/protocol/serialization/ManufacturingInfoDeserializer.java
Show resolved
Hide resolved
Signed-off-by: adarsh-intel <[email protected]>
adarshan-intel
force-pushed
the
fuzzing_fixes_DI_10
branch
from
293b1c8
to
894102f
Compare
adarshan-intel
requested review from
DukeDavis12,
KiranSukhavasi and
v-vasavi
DukeDavis12
approved these changes
Nov 7, 2023
KiranSukhavasi
approved these changes
Nov 7, 2023
KiranSukhavasi
approved these changes
Nov 7, 2023
DukeDavis12
approved these changes
Nov 7, 2023
adarshan-intel
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.