Skip to content
This repository has been archived by the owner on Aug 31, 2022. It is now read-only.

Avoid polluting global scope in a module-supporting environment #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jscinoz
Copy link

@jscinoz jscinoz commented Nov 3, 2017

  • Assign global shoestring and $ in UMD wrapper when we're in a non-module (i.e. browser) environment
  • Remove dollar.js and inline assignment of win.shoestring in shoestring.js

Resolves #100
Resolves #129

@jscinoz jscinoz changed the title Avoid polluting global scop in a module-supporting environment Avoid polluting global scope in a module-supporting environment Nov 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant