-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable cells while loadng #14961
Disable cells while loadng #14961
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add 'wire:target' => implode(',', \Filament\Tables\Table::LOADING_TARGETS),
for these so that the loading indicator isn't activated while the field is being edited
Is it ok now? I added them, even though I couldnt really see any loading indicators 🤷 |
Sorry, I meant loading state (disabled attribute) not loading indicator |
Also, do these changes need to be made for the button in the ToggleColumn? |
Yes, they do. Thanks for reminding |
Is it ready now? |
Thanks |
You're welcome! Dont forget to close the issue |
Thanks for the reminder, I forgot |
@@ -49,6 +50,8 @@ public function toEmbeddedHtml(): string | |||
$inputAttributes = $this->getExtraInputAttributeBag() | |||
->merge([ | |||
'disabled' => $isDisabled, | |||
'wire:loading.attr' => 'disabled', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this been tested to work with disabled columns?
I commented about that on the previous PR too since I believe that was the original challenge I couldn't work around last year.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it works. Unless Im still missing your point... If the column is disabled, then all cells will be disabled and during loading they will stay disabled. If some of them are enabled, then they will get disabled until they're finished loading. Is this what you mean with disabled columns?
Description
This PR reopens #14947 (this time for v4) )and closes #7294.
Visual changes
2024-12-02.00-50-38.mp4
Functional changes
composer cs
command.