Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TagsInput closing filters when removing tag from list #15046

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

TheSkybreaker
Copy link
Contributor

Description

Hello,

When using TagsInput to make a custom table filter, clicking the "X" to remove a tag causes the filters to close.
If the user needs to remove more than one tag they have to open the filters again and remove the tags one by one (or reset the filters and insert again what to keep)

Stopping the event propagation on click prevents this side effect

Visual changes

None

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@danharrin danharrin added the bug Something isn't working label Dec 10, 2024
@danharrin danharrin added this to the v3 milestone Dec 10, 2024
@danharrin danharrin merged commit 04bde6d into filamentphp:3.x Dec 10, 2024
1 check passed
@danharrin
Copy link
Member

Thanks

@TheSkybreaker TheSkybreaker deleted the fix-tagsinput-filter branch December 10, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants