Allow closure based table Group labels
#15196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danharrin
requested changes
Dec 31, 2024
Comment on lines
+89
to
+93
| foreach ($groups as $group) { | ||
| if ($group instanceof Group) { | ||
| $group->table($this); | ||
| } | ||
| } |
There was a problem hiding this comment.
If groups are passed in a closure I don't think the table gets passed, I think the table needs to be injected in when the groups property is consumed
Comment on lines
+75
to
+77
| if ($group instanceof Group) { | ||
| $group->table($this); | ||
| } |
There was a problem hiding this comment.
Can we move this to the place where the defaultGroup gets read so if we introduce closure support this won't break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the
getLabel()method of Table Groups to be based on a closure. It also ensures that the group evaluation parameters for$table/$livewireare correctly received. In line with other code the table is set on the group as soon as possible (when pushing the groups), or on instantiation of the groups when only providing the string attribute.Thanks!