Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add Form and Table to prevent collision while creating a resource #15238

Merged
merged 2 commits into from
Jan 4, 2025
Merged

fix: add Form and Table to prevent collision while creating a resource #15238

merged 2 commits into from
Jan 4, 2025

Conversation

borjajimnz
Copy link
Contributor

Description

This prevents class collisions when the model is called "Form", "Table", or "Resource", as described in #13552

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@danharrin danharrin added the bug Something isn't working label Jan 4, 2025
@danharrin danharrin added this to the v3 milestone Jan 4, 2025
@danharrin danharrin merged commit fd981c3 into filamentphp:3.x Jan 4, 2025
10 checks passed
@danharrin
Copy link
Member

Thanks

@danharrin danharrin mentioned this pull request Jan 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Roadmap
Status: Done
Milestone
v3
Development

Successfully merging this pull request may close these issues.
2 participants
@borjajimnz @danharrin