fix: prevent multiple evaluations when getStateUsing is called #14852 #15246
Conversation
|
this breaks the use of fn and function within getStateUsing! |
Have you tested it @mc-fu ? is not breaking nothing for me. |
| @@ -76,7 +76,7 @@ public function getState(): mixed | |||
| } | |||
|
|
|||
| $state = ($this->getStateUsing !== null) ? | |||
| $this->evaluate($this->getStateUsing) : | |||
| $this->getStateUsing : | |||
| $this->getStateFromRecord(); | |||
|
|
|||
| if (is_string($state) && ($separator = $this->getSeparator())) { | |||
There was a problem hiding this comment.
The breaking comment is correct, if the function returns a string that needs separating here or a blank value it would break
|
Yeah, sorry, I needed to be more precise: When using "
|
|
This is more complex than I initially thought; I'll need some time to process it. I'll reopen the PR if I find a way to handle it. |
Description
As mentioned in #14852, this issue was causing multiple evaluations. This fix ensures that only the final evaluation is performed, which I believe is the correct approach.
Functional changes
composer cscommand.