Refactor: assertTableFilterExists to allow passing in a callback
#15302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've refactored the
assertTableFilterExiststest function to allow you to pass a callback function, so that you can access the filter itself like you can do with theassertTableColumnExists.I couldn't see
assertTableFilterExistsin the docs so I've added it in as well as docs on the new functionality.I also couldn't see the stub anywhere so I've added that as well.
I think this feature will be useful if you want to test a specific part of your filter, for example making sure that the label is right.
Visual changes
No visual changes.
Functional changes
composer cscommand.