Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix that resolves the issue when trying to add a new key-value pair. #15420

Closed
wants to merge 2 commits into from

Conversation

borjajimnz
Copy link
Contributor

Description

Fix that resolves the issue when trying to add a new key-value pair described in #15416.
This was my fault in the last fix. now is solved. soz!

Visual changes

https://www.youtube.com/watch?v=WP4hgMzWZ4A

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@rickzim
Copy link

rickzim commented Jan 24, 2025

Hey! i used the updated code in the demo project but now theres another weird issue (maybe its just me but it doesn't hurt to test it)

if you add new rows to a KeyValue field, and populate it, it will start doing weird things like removing other rows.

It is the easiest to trigger if you add multiple empty lines at ones, and then try to populate them.

@danharrin
Copy link
Member

Adding rows definitely needs to update the state otherwise it will be out of sync

@danharrin
Copy link
Member

I am going to revert the old PR and make a new release

@danharrin
Copy link
Member

Going to close this, but please reopen when the above issue is addressed

@danharrin danharrin closed this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants