-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Slider #15507
base: 4.x
Are you sure you want to change the base?
Feature: Slider #15507
Conversation
add padding option in slider component
FYI this will be on hold and not reviewed until after v4.0.0-alpha1 is released |
Yes, I'm aware |
@thethunderturner Would you consider keeping two libraries? |
Can you elaborate? What do you mean by two libraries? |
can this slider have just 1 value instead of 2 bars? the text above the bar is it editable by clicking on it? |
You added: nouislider, wnumb. |
Yes it can, if you check the screenshots that I added, there is a simple example and more complicated example |
I will think about it. |
https://github.com/n3r4zzurr0/range-slider-input Can be considered too as its default stylings seem to look nicer or if the filament team prefer something more lightweight. I experiment with it briefly recently in a brief attempt to learn about making filament custom field for the 1st time
But it likely has way less features than nouislider and I'm sure community can make the nouislider looks nicer as I'm very bad at frontend Also just curious, what are the reasons why it has to go to filament 4 and not filament 3? |
typos in docs
Description
Closes #12728
This PR aims to add the slider component natively on filament. This PR was originally scheduled for 3.x for which I already made a PR, then it was rescheduled for 4.1. Now im seeing Slider component is rescheduled for 4.0. Therefore I decided to revisit, and make it work for 4.x. I have also written the documentation for it.
Visual changes
The only things thast are probably missing, are test cases. But that can be done after the team makes sure the main code is ok.
Functional changes
composer cs
command.