Fix custom notification object

[wychoong]

• Changes have been thoroughly tested to not break existing functionality.
• New functionality has been documented or existing documentation has been updated to reflect changes.
• Visual changes are explained in the PR description using a screenshot/recording of before and after.

closes #9268

when recreating the notification object from array, Notification class resolved the correct CustomNotification but the CustomNotification::fromArray is not called again. this PR fixes that by checking if the notification object resolved from container is custom and its called from Notification class to ensure its only called once and prevent infinite loop

another approach would be in livewire\Notifications to resolved the notification object but that would have multiple useless instance created and more code changes that I not able to test

[danharrin]

Duplicate of #9299?

[wychoong]

Duplicate of #9299?

Fixed the same issue without exposing unnecessary info

[danharrin]

I don't think I understand how it works?

[wychoong]

I don't think I understand how it works?

in this file

filament/packages/notifications/src/Livewire/Notifications.php

Lines 35 to 42 in 73d6c1c

	public function pullNotificationsFromSession(): void
	{
	foreach (session()->pull('filament.notifications') ?? [] as $notification) {
	$notification = Notification::fromArray($notification);
	$this->pushNotification($notification);
	}
	}

Notification::fromArray($notification) is Filament\Notifications\Notification

here it will return the CustomNotification from the make method

filament/packages/notifications/src/Notification.php

Lines 88 to 91 in 73d6c1c

	public static function fromArray(array $data): static
	{
	$static = static::make($data['id'] ?? Str::random());
	$static->actions(

and it continues to configure the object with the array data, thus it never gets to call to CustomNotification::fromArray, this can be verified by dd in CustomNotification::fromArray

with this fix

if (is_subclass_of($static::class, self::class) && get_called_class() === self::class) {
    $static = $static::fromArray($data);
}

it checks if the $static notification class is extended from the base Notification.
And also make sure it is called from Notification. This is because we need to call parent::fromArray in the CustomNotification to ensure the rest of properties are set.
Without these checks it will be infinite loops as base->custom->base->custom->...

[danharrin]

Thanks!