Fix/remove hardcoded npm package #9410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danharrin
requested changes
Nov 2, 2023
Comment on lines
66
to
68
| $cssFilePath, | ||
| $tailwindConfigFilePath, | ||
| ])) { |
There was a problem hiding this comment.
Please revert the formatting change here
| $this->info("Using NPM v{$npmVersion[0]}"); | ||
| $this->info("Using {$pm} v{$pmVersion[0]}"); | ||
|
|
||
| $installCommand = $pm === 'yarn' ? 'yarn add' : "{$pm} install"; |
There was a problem hiding this comment.
Please refactor this to use a match() statement
|
|
||
| if ($npmVersionExistCode !== 0) { | ||
| exec($pm . ' -v', $pmVersion, $pmVersionExistCode); |
There was a problem hiding this comment.
Please convert the concatenation to using "{$}" syntax
packages/panels/docs/11-themes.md
Outdated
| @@ -121,6 +121,12 @@ If you have multiple panels, you can specify the panel you want to create a them | |||
| php artisan make:filament-theme admin | |||
| ``` | |||
|
|
|||
| By default, command will use node package manager with npm. If you want to use different package manager use `--pm` option: | |||
There was a problem hiding this comment.
Suggested change
| By default, command will use node package manager with npm. If you want to use different package manager use `--pm` option: | |
| By default, this command will use NPM to install dependencies. If you want to use a different package manager, you can use the `--pm` option: |
added 3 commits
November 2, 2023 17:21
danharrin
reviewed
Nov 2, 2023
|
Thanks |
valpuia
reviewed
Nov 3, 2023
| @@ -108,7 +115,7 @@ public function handle(): int | |||
| $this->components->bulletList([ | |||
| "First, add a new item to the `input` array of `vite.config.js`: `resources/css/filament/{$panelId}/theme.css`.", | |||
| "Next, register the theme in the {$panelId} panel provider using `->viteTheme('resources/css/filament/{$panelId}/theme.css')`", | |||
| 'Finally, run `npm run build` to compile the theme.', | |||
| "Finally, run `{$pm} run build` to compile the theme.", | |||
There was a problem hiding this comment.
I've never tried with bun but bun build is the command right, not bun run build? https://bun.sh/docs/bundler
There was a problem hiding this comment.
tried both build and run build both works, same with yarn works yarn run build and yarn build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current make:filament-theme command had hardcoded npm package giving no possibility to use other package managers such as yarn or bun. This PR adds a new --pm option to the command which will let user to enter what package manager command should use.
Example usage:
php artisan make:filament-theme admin --pm=bunphp artisan make:filament-theme admin --pm=yarn