Now allowing defaultSort()'s argument to be a Closure.

[telkins]

The Filament\Tables\Table\Concerns\CanSortRecords trait's defaultSort() method has the following signature:

public function defaultSort(string | Closure | null $column, string | Closure | null $direction = 'asc'): static

The $direction argument, if not null, is passed through Str::lower() and then assigned to $this->defaultSortDirection, which is a nullable string.

There is at least one problem: if a Closure is passed, then Str::lower() chokes on it.

I decided to do the following:

• pass $direction through evaluate() right away and allow the rest of the code/types to remain as they are currently
• remove the "last minute" call to evaluate() in getDefaultSortDirection()

All existing tests pass. No new tests were added.

[telkins]

@awcodes FYI....

There were at least two ways to do this, depending on when/where evaluate() should be called on whatever the user passed in. I opted to go one way first, keeping evaluate() to be called late....but then decided to go with the "cleaner" solution, which was to move evaluate() to the beginning of the process.

I have mixed feelings, as there may be advantages to having evaluate() called later vs earlier. 🤔

[danharrin]

Can you please explain why you need to pass a function in?

[danharrin]

Evaluation should always happen in getters, it should not be evaluated here.

[danharrin]

ive changed it

[telkins]

Evaluation should always happen in getters, it should not be evaluated here.

I had done that first, as you may have seen. I noticed that this was normally in the getters. But, I changed my mind thinking you might prefer to keep the changes smaller.

[telkins]

ive changed it

Thx. You did what I had done on my first iteration. Makes me feel good that I had the right solution...before I changed it. 😅

[telkins]

Can you please explain why you need to pass a function in?

Sure. I have a filter that filters from today forward or from today backward, depending.

I wasn't able to find a way to sort in the filter. The orderBy() doesn't seem to be respected. So, I found that I could pass a function in for defaultSort()'s $direction argument, determine the filter state, and then sort accordingly.

If there's a better way, I'd love to know about it.

In any case, this was a bug worth fixing, I thought. 🤓