Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): upgrade graphsync for identity CID fix #1704

Merged
merged 2 commits into from
Sep 21, 2023
Merged

chore(deps): upgrade graphsync for identity CID fix #1704

merged 2 commits into from
Sep 21, 2023

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Sep 20, 2023

No description provided.

@rvagg rvagg requested a review from LexLuthr September 20, 2023 00:19
@rvagg
Copy link
Member Author

rvagg commented Sep 20, 2023

test failing because the test itself uses an identity CID for "missing" .. working on some additional tests and possible changes to handle identity CIDs through a retrieval cycle

@rvagg
Copy link
Member Author

rvagg commented Sep 20, 2023

OK, this is a bit of a problem and I'm going to have to take an alternative approach with graphsync because of classic online deal flow and it's reliance on identity CIDs being non-simulated blocks everywhere.

@rvagg
Copy link
Member Author

rvagg commented Sep 20, 2023

🥳

Depends on filecoin-project/boost-graphsync#7

OK, so the overall impact here is negligible, since filecoin-project/boost-graphsync#7 rolls back most of what I did in the previous iteration. It turns out that the old online deal flow limits our options for dealing with identity CIDs but we can wac-a-mole this one in other ways.

Test added in here to demonstrate a successful round-trip that traverses through an identity CID.

@rvagg rvagg mentioned this pull request Sep 20, 2023
Merged
LexLuthr
LexLuthr reviewed Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new itest is still not in circleCI.

@rvagg rvagg requested a review from LexLuthr September 21, 2023 08:07
LexLuthr
LexLuthr approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rvagg rvagg merged commit 0278a9b into main Sep 21, 2023
21 checks passed
@rvagg rvagg deleted the rvagg/gs-upgr branch September 21, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LexLuthr LexLuthr LexLuthr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Boost
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvagg @LexLuthr