Reintroduce randomness precompile #1576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
reviewed
Aug 26, 2024
| /// | ||
| /// | Param | Value | | ||
| /// |------------------|---------------------------| | ||
| /// | randomness_epoch | U256 - low i64 | |
|
|
||
| let randomness_epoch = input_params.read_value()?; | ||
| let entropy_length: u32 = input_params.read_value()?; | ||
| let entropy = input_params.read_padded(entropy_length.try_into().unwrap_or(0)); |
There was a problem hiding this comment.
Are you sure we want the unwrap or zero here? u32::MAX will turn into 0, I think we want to fail in that case.
| Some(resolve_address::<RT>), // 0xfe00..01 | ||
| Some(lookup_delegated_address::<RT>), // 0xfe00..02 | ||
| Some(call_actor::<RT>), // 0xfe00..03 | ||
| None, // 0xfe00..04 DISABLED | ||
| Some(call_actor_id::<RT>), // 0xfe00..05 | ||
| Some(get_randomness::<RT>), // 0xfe00..06 |
There was a problem hiding this comment.
nit: re-use 4? This sued to be 4.
|
Reverting this to a draft while we settle FIP / design questions. |
1 task
|
An alternative which just exposes the beacon values: #1577 |
|
I'm happy with your approach @anorth, closing in favor of that one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of filecoin-project/FIPs#1048
cc @anorth