Skip to content

Commit

Permalink
chore: try to get Clippy working
Browse files Browse the repository at this point in the history
  • Loading branch information
vmx committed Aug 14, 2024
1 parent ff292d5 commit f711352
Showing 1 changed file with 48 additions and 45 deletions.
93 changes: 48 additions & 45 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,30 +23,31 @@ jobs:
MSRV=$(cargo metadata --format-version 1 --no-deps | jq -r 'first(.packages[].rust_version | select(.))')
echo "MSRV=$MSRV" >> "$GITHUB_OUTPUT"
linux:
strategy:
matrix:
include:
- name: "default features"
cargo-args: ""
- name: "CUDA and OpenCL"
cargo-args: "--features cuda,opencl"
- name: "CUDA only"
cargo-args: "--no-default-features --features cuda"
- name: "OpenCL only"
cargo-args: "--no-default-features --features opencl"
needs: set-msrv
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{needs.set-msrv.outputs.msrv}}
#- name: Install opencl
# run: sudo apt-get install -y ocl-icd-opencl-dev
#- run: ${{ matrix.deps }}
- name: Test with ${{ matrix.name }}
run: cargo test --workspace ${{ matrix.cargo-args }} -- --nocapture --test-threads 1
#linux:
# strategy:
# matrix:
# include:
# - name: "default features"
# cargo-args: ""
# - name: "CUDA and OpenCL"
# cargo-args: "--features cuda,opencl"
# - name: "CUDA only"
# cargo-args: "--no-default-features --features cuda"
# - name: "OpenCL only"
# cargo-args: "--no-default-features --features opencl"
# needs: set-msrv
# runs-on: ubuntu-latest
# name: Linux ${{ matrix.name }}
# steps:
# - uses: actions/checkout@v4
# - uses: dtolnay/rust-toolchain@master
# with:
# toolchain: ${{needs.set-msrv.outputs.msrv}}
# #- name: Install OpenCL
# # run: sudo apt-get install -y ocl-icd-opencl-dev
# #- run: ${{ matrix.deps }}
# - name: Test with ${{ matrix.name }}
# run: cargo test --workspace ${{ matrix.cargo-args }} -- --nocapture --test-threads 1

clippy_check:
needs: set-msrv
Expand All @@ -57,6 +58,8 @@ jobs:
with:
toolchain: ${{ needs.set-msrv.outputs.msrv }}
components: clippy
- name: Install OpenCL
run: sudo apt-get install -y ocl-icd-opencl-dev
- name: Run cargo clippy default features
run: cargo clippy --workspace --all-targets -- -D warnings
#- name: Run cargo clippy with cuda and opencl features
Expand All @@ -66,24 +69,24 @@ jobs:
#- name: Run cargo clippy with opencl feature
# run: cargo clippy --workspace --all-targets --no-default-features --features opencl -- -D warnings

check_fmt_and_docs:
needs: set-msrv
name: Checking fmt and docs
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ needs.set-msrv.outputs.msrv }}
components: rustfmt
- name: fmt
run: cargo fmt --all -- --check
- name: Docs
env:
# Making sure that the documentation can be built without having the NVIDIA toolkit
# installed.
DOCS_RS: true
#run: cargo doc
run: |
cargo rustdoc --package ec-gpu --all-features -- -D warnings
cargo rustdoc --package ec-gpu-gen --all-features -- -D warnings
#check_fmt_and_docs:
# needs: set-msrv
# name: Checking fmt and docs
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v4
# - uses: dtolnay/rust-toolchain@master
# with:
# toolchain: ${{ needs.set-msrv.outputs.msrv }}
# components: rustfmt
# - name: fmt
# run: cargo fmt --all -- --check
# - name: Docs
# env:
# # Making sure that the documentation can be built without having the NVIDIA toolkit
# # installed.
# DOCS_RS: true
# #run: cargo doc
# run: |
# cargo rustdoc --package ec-gpu --all-features -- -D warnings
# cargo rustdoc --package ec-gpu-gen --all-features -- -D warnings

0 comments on commit f711352

Please sign in to comment.