Changes after CR

filecoin-project · Nov 15, 2024 · 218479c · 218479c
1 parent 49a3975
commit 218479c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/fplus-http-server/src/router/application.rs b/fplus-http-server/src/router/application.rs
@@ -129,7 +129,7 @@ pub async fn propose(
         )
         .await
     {
-        Ok(_) => HttpResponse::Ok().body(serde_json::to_string_pretty("Success").unwrap()),
+        Ok(app) => HttpResponse::Ok().body(serde_json::to_string_pretty(&app).unwrap()),
         Err(e) => HttpResponse::BadRequest().body(e.to_string()),
     }
 }
@@ -241,7 +241,7 @@ pub async fn approve(
         )
         .await
     {
-        Ok(_) => HttpResponse::Ok().body(serde_json::to_string_pretty("Success").unwrap()),
+        Ok(app) => HttpResponse::Ok().body(serde_json::to_string_pretty(&app).unwrap()),
         Err(e) => HttpResponse::BadRequest().body(e.to_string()),
     }
 }

diff --git a/fplus-lib/src/core/mod.rs b/fplus-lib/src/core/mod.rs
@@ -1036,7 +1036,7 @@ impl LDNApplication {
         owner: String,
         repo: String,
         new_allocation_amount: Option<String>,
-    ) -> Result<(), LDNError> {
+    ) -> Result<ApplicationFile, LDNError> {
         // TODO: Convert DB errors to LDN Error
         // Get multisig threshold from the database
         let db_allocator = match get_allocator(&owner, &repo).await {
@@ -1172,7 +1172,7 @@ impl LDNApplication {
                                 }
                                 Err(e) => log::warn!("Failed to get pull request by head: {}", e),
                             };
-                            Ok(())
+                            Ok(app_file)
                         }
                         None => Err(LDNError::New(format!(
                             "Application issue {} cannot be proposed(1)",
@@ -1415,7 +1415,7 @@ impl LDNApplication {
         owner: String,
         repo: String,
         new_allocation_amount: Option<String>,
-    ) -> Result<(), LDNError> {
+    ) -> Result<ApplicationFile, LDNError> {
         // Get multisig threshold from the database
         let db_allocator = match get_allocator(&owner, &repo).await {
             Ok(allocator) => allocator.unwrap(),
@@ -1519,7 +1519,7 @@ impl LDNApplication {
 
         self.issue_updates(&app_file.issue_number, comment, label)
             .await?;
-        Ok(())
+        Ok(app_file)
     }
 
     async fn parse_application_issue(