Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quality duration multiplier #805

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Add quality duration multiplier #805

merged 2 commits into from
Dec 20, 2024

Conversation

Kubuxu
Copy link
Contributor

@Kubuxu Kubuxu commented Dec 18, 2024

No description provided.

Signed-off-by: Jakub Sztandera <[email protected]>
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 68.84%. Comparing base (d4f3a0c) to head (4d2d802).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
gpbft/options.go 62.50% 2 Missing and 1 partial ⚠️
manifest/manifest.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #805      +/-   ##
==========================================
- Coverage   69.38%   68.84%   -0.55%     
==========================================
  Files          78       81       +3     
  Lines        7957     8255     +298     
==========================================
+ Hits         5521     5683     +162     
- Misses       1971     2087     +116     
- Partials      465      485      +20     
Files with missing lines Coverage Δ
gpbft/gpbft.go 89.14% <100.00%> (+0.02%) ⬆️
gpbft/options.go 58.22% <62.50%> (+0.48%) ⬆️
manifest/manifest.go 53.04% <25.00%> (-0.71%) ⬇️

... and 7 files with indirect coverage changes

@Kubuxu Kubuxu linked an issue Dec 19, 2024 that may be closed by this pull request
@Kubuxu Kubuxu requested a review from masih December 19, 2024 13:37
Copy link
Member

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on terminology, otherwise LGTM.

gpbft/options.go Show resolved Hide resolved
MaxLookaheadRounds uint64
Delta time.Duration
DeltaBackOffExponent float64
QualityDurationMultiplier float64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QualityDeltaMultiplier and rename across the code?

The rationale being: the duration of quality is not exactly governed by that multiplier. It will finish on strong quorum of proposal. Calling it a Delta multiplier is clearer because it is that.

@Kubuxu Kubuxu enabled auto-merge December 20, 2024 15:47
@Kubuxu Kubuxu added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 135bfe6 Dec 20, 2024
12 checks passed
@Kubuxu Kubuxu deleted the feat/quality-multi branch December 20, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce an explicit delay for QUALITY phase
2 participants