-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quality duration multiplier #805
Conversation
Signed-off-by: Jakub Sztandera <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #805 +/- ##
==========================================
- Coverage 69.38% 68.84% -0.55%
==========================================
Files 78 81 +3
Lines 7957 8255 +298
==========================================
+ Hits 5521 5683 +162
- Misses 1971 2087 +116
- Partials 465 485 +20
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment on terminology, otherwise LGTM.
manifest/manifest.go
Outdated
MaxLookaheadRounds uint64 | ||
Delta time.Duration | ||
DeltaBackOffExponent float64 | ||
QualityDurationMultiplier float64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QualityDeltaMultiplier
and rename across the code?
The rationale being: the duration of quality is not exactly governed by that multiplier. It will finish on strong quorum of proposal. Calling it a Delta multiplier is clearer because it is that.
Signed-off-by: Jakub Sztandera <[email protected]>
No description provided.