Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deal state schema to match Rust #215

Merged

Conversation

anorth
Copy link
Member

@anorth anorth commented Sep 5, 2023

#210 doesn't yet include updating the market DealState schema. This PR isn't a complete resolution (I'm no longer familiar with the rest of the migration code), but intended to be cherry-picked or otherwise cloned into #210 as a prompt to migrate those objects.

See filecoin-project/builtin-actors#1347 and filecoin-project/builtin-actors#1403

@anorth
Copy link
Member Author

anorth commented Sep 5, 2023

Note that I have not ported changes to the state checks from Rust to Go. My understanding is that these have drifted in many places because no-one is maintaining the Go version. This is a predictable result of the code duplication involved. However, it would be good to prevent the problem getting worse.

@anorth anorth force-pushed the anorth/v12-no-deal-allocatio branch from 2c1766e to 1fcc990 Compare September 5, 2023 03:04
@snissn snissn merged commit 606d9d5 into mikers/sector_deal_ids_index_cached Sep 5, 2023
@snissn snissn deleted the anorth/v12-no-deal-allocatio branch September 5, 2023 22:47
Copy link
Contributor

@snissn snissn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants