Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add nv24 skeleton #299

Merged
merged 6 commits into from
Aug 7, 2024
Merged

feat: Add nv24 skeleton #299

merged 6 commits into from
Aug 7, 2024

Conversation

kamuik16
Copy link
Contributor

@kamuik16 kamuik16 commented Aug 3, 2024

ref #295
cc @rjan90
Lmk if I have done something wrong 🙃.

@rjan90
Copy link
Contributor

rjan90 commented Aug 5, 2024

Hey @kamuik16! Thanks for working on this, it seems like there is a lot of duplicate files here, with just a = ending to them, and they should not be there. List of some of these duplicates:

builtin/v15/check.go=
builtin/v15/cron/invariants.go=
builtin/v15/datacap/datacap_state.go=
builtin/v15/datacap/invariants.go=
builtin/v15/evm/evm_state.go=
builtin/v15/evm/invariants.go=
builtin/v15/gen/gen.go=
builtin/v15/init/init_actor_state.go=
builtin/v15/init/invariants.go=
builtin/v15/market/cbor_gen.go=
builtin/v15/market/deal_test.go=
builtin/v15/market/invariants.go=
builtin/v15/market/market_state.go=
builtin/v15/market/market_types.go=
builtin/v15/market/methods.go=
builtin/v15/market/set_multimap.go=
builtin/v15/miner/cbor_gen.go=
builtin/v15/miner/deadline_state.go=
builtin/v15/miner/deadlines.go=
builtin/v15/miner/invariants.go=
builtin/v15/miner/methods.go=
builtin/v15/miner/miner_state.go=
builtin/v15/miner/miner_types.go=
builtin/v15/miner/monies.go=
builtin/v15/miner/partition_state.go=

@kamuik16
Copy link
Contributor Author

kamuik16 commented Aug 5, 2024

Hey @kamuik16! Thanks for working on this, it seems like there is a lot of duplicate files here, with just a = ending to them, and they should not be there. List of some of these duplicates:

builtin/v15/check.go=
builtin/v15/cron/invariants.go=
builtin/v15/datacap/datacap_state.go=
builtin/v15/datacap/invariants.go=
builtin/v15/evm/evm_state.go=
builtin/v15/evm/invariants.go=
builtin/v15/gen/gen.go=
builtin/v15/init/init_actor_state.go=
builtin/v15/init/invariants.go=
builtin/v15/market/cbor_gen.go=
builtin/v15/market/deal_test.go=
builtin/v15/market/invariants.go=
builtin/v15/market/market_state.go=
builtin/v15/market/market_types.go=
builtin/v15/market/methods.go=
builtin/v15/market/set_multimap.go=
builtin/v15/miner/cbor_gen.go=
builtin/v15/miner/deadline_state.go=
builtin/v15/miner/deadlines.go=
builtin/v15/miner/invariants.go=
builtin/v15/miner/methods.go=
builtin/v15/miner/miner_state.go=
builtin/v15/miner/miner_types.go=
builtin/v15/miner/monies.go=
builtin/v15/miner/partition_state.go=

Fixed in 729ea45.

Somehow these files were generated, not sure how. My bad.

@rjan90 rjan90 linked an issue Aug 6, 2024 that may be closed by this pull request
builtin/v15/check.go Outdated Show resolved Hide resolved
Copy link
Contributor

@rjan90 rjan90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@rjan90 rjan90 merged commit de9214e into filecoin-project:master Aug 7, 2024
8 checks passed
@kamuik16 kamuik16 deleted the nv24 branch August 7, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

2 participants