-
Notifications
You must be signed in to change notification settings - Fork 39
Replace ActivateDeals with BatchActivateDeals and update params (v12–latest) #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the go-state-types codebase to align with changes in builtin actors v12 onwards, where ActivateDeals was replaced with BatchActivateDeals. The PR systematically updates all affected versions (v12-v17) to use the new API.
- Method name change from
ActivateDealstoBatchActivateDeals - Parameter type change from
ActivateDealsParamstoBatchActivateDealsParams - Updated parameter structure to support sector-specific fields including
SectorNumberandComputeCid
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| builtin/v*/market/methods.go | Updates method metadata to use BatchActivateDeals instead of ActivateDeals |
| builtin/v*/market/market_types.go | Replaces ActivateDealsParams with BatchActivateDealsParams and adds SectorNumber field to SectorDeals |
| builtin/v*/market/cbor_gen.go | Regenerated CBOR marshaling/unmarshaling code for the updated parameter structures |
| builtin/v*/gen/gen.go | Updates CBOR generation to reference the new BatchActivateDealsParams type |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #414 +/- ##
=======================================
Coverage 3.60% 3.60%
=======================================
Files 733 733
Lines 200268 200238 -30
=======================================
Hits 7212 7212
+ Misses 190789 190759 -30
Partials 2267 2267
🚀 New features to boost your workflow:
|
|
@jintukumardas looks like the go-check is failing, because not all the changes are go-fmt´ed properly |
Done, thanks! |
|
Hi @rjan90 , just checking if the changes look good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, thanks!
Closes: #409
From builtin-actor v12 onwards,
ActivateDealswas replaced withBatchActivateDeals, but go-state-types was still using the old method.This change updates all affected versions (v12–latest) to align with the
current actor API.