Skip to content

Conversation

@jintukumardas
Copy link
Contributor

Closes: #409

From builtin-actor v12 onwards, ActivateDeals was replaced with
BatchActivateDeals, but go-state-types was still using the old method.

This change updates all affected versions (v12–latest) to align with the
current actor API.

  • Method rename: ActivateDeals -> BatchActivateDeals
  • Param type change: ActivateDealsParams -> BatchActivateDealsParams
  • Updated parameter structure with sector-specific fields
  • Regenerated CBOR for updated params

Copilot AI review requested due to automatic review settings September 21, 2025 21:35
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Sep 21, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the go-state-types codebase to align with changes in builtin actors v12 onwards, where ActivateDeals was replaced with BatchActivateDeals. The PR systematically updates all affected versions (v12-v17) to use the new API.

  • Method name change from ActivateDeals to BatchActivateDeals
  • Parameter type change from ActivateDealsParams to BatchActivateDealsParams
  • Updated parameter structure to support sector-specific fields including SectorNumber and ComputeCid

Reviewed Changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.

File Description
builtin/v*/market/methods.go Updates method metadata to use BatchActivateDeals instead of ActivateDeals
builtin/v*/market/market_types.go Replaces ActivateDealsParams with BatchActivateDealsParams and adds SectorNumber field to SectorDeals
builtin/v*/market/cbor_gen.go Regenerated CBOR marshaling/unmarshaling code for the updated parameter structures
builtin/v*/gen/gen.go Updates CBOR generation to reference the new BatchActivateDealsParams type

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rjan90 rjan90 moved this from 📌 Triage to 🔎 Awaiting Review in FilOz Sep 22, 2025
@rjan90 rjan90 requested a review from rvagg September 22, 2025 06:42
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 0% with 264 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.60%. Comparing base (dae5e9e) to head (8787400).

Files with missing lines Patch % Lines
builtin/v12/market/cbor_gen.go 0.00% 43 Missing ⚠️
builtin/v13/market/cbor_gen.go 0.00% 43 Missing ⚠️
builtin/v14/market/cbor_gen.go 0.00% 43 Missing ⚠️
builtin/v15/market/cbor_gen.go 0.00% 43 Missing ⚠️
builtin/v16/market/cbor_gen.go 0.00% 43 Missing ⚠️
builtin/v17/market/cbor_gen.go 0.00% 43 Missing ⚠️
builtin/v12/gen/gen.go 0.00% 1 Missing ⚠️
builtin/v13/gen/gen.go 0.00% 1 Missing ⚠️
builtin/v14/gen/gen.go 0.00% 1 Missing ⚠️
builtin/v15/gen/gen.go 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #414   +/-   ##
=======================================
  Coverage    3.60%    3.60%           
=======================================
  Files         733      733           
  Lines      200268   200238   -30     
=======================================
  Hits         7212     7212           
+ Misses     190789   190759   -30     
  Partials     2267     2267           
Files with missing lines Coverage Δ
builtin/v12/gen/gen.go 0.00% <0.00%> (ø)
builtin/v13/gen/gen.go 0.00% <0.00%> (ø)
builtin/v14/gen/gen.go 0.00% <0.00%> (ø)
builtin/v15/gen/gen.go 0.00% <0.00%> (ø)
builtin/v16/gen/gen.go 0.00% <0.00%> (ø)
builtin/v17/gen/gen.go 0.00% <0.00%> (ø)
builtin/v12/market/cbor_gen.go 0.00% <0.00%> (ø)
builtin/v13/market/cbor_gen.go 0.00% <0.00%> (ø)
builtin/v14/market/cbor_gen.go 0.00% <0.00%> (ø)
builtin/v15/market/cbor_gen.go 0.00% <0.00%> (ø)
... and 2 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rjan90
Copy link
Contributor

rjan90 commented Sep 22, 2025

@jintukumardas looks like the go-check is failing, because not all the changes are go-fmt´ed properly

@jintukumardas
Copy link
Contributor Author

@jintukumardas looks like the go-check is failing, because not all the changes are go-fmt´ed properly

Done, thanks!

@jintukumardas
Copy link
Contributor Author

Hi @rjan90 , just checking if the changes look good now.

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thanks!

@github-project-automation github-project-automation bot moved this from 🔎 Awaiting Review to ✔️ Approved by reviewer in FilOz Sep 26, 2025
@rvagg rvagg merged commit 2866a74 into filecoin-project:master Sep 26, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

Update method in market actor

4 participants