Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps, replace deprecated mock clock lib #495

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Dec 17, 2024

This is an attempt to deal with #492 by upgrading the go-libipni dependency. I've upgrade almost everything else in the process, with some caveats:

  • I've gone off the previously tagged boxo 894484c9e656 which was there to fix a bug we consistently experience(d) here, 🤞 that it's dealt with in some form, or that current usage patterns of Lassie don't hit it (no Saturn).
  • I've held back from the very latest boxo because it has a heap of breaking bitswap changes I don't have time to grok.
  • I hard-wired older versions in the e2e test for storetheindex and ipni-cli which I haven't updated here. I think I might need to do some coordinating with frisbii to make those happy, and I don't have time so I'm leaving it for now.

Also, I haven't actually tested that it works, I don't have a good CID to query the indexer with that would give me an http-path response (I can't get any good responses from ipni atm, so 🤷)

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.40%. Comparing base (53f405f) to head (c643c7f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #495      +/-   ##
==========================================
- Coverage   75.78%   75.40%   -0.38%     
==========================================
  Files          87       87              
  Lines        6661     6661              
==========================================
- Hits         5048     5023      -25     
- Misses       1338     1352      +14     
- Partials      275      286      +11     
Files with missing lines Coverage Δ
pkg/internal/candidatebuffer/candidatebuffer.go 89.83% <ø> (ø)
pkg/internal/mockindexer/mockindexer.go 62.50% <ø> (ø)
pkg/internal/testutil/mockclient.go 54.34% <ø> (ø)
pkg/internal/testutil/mockroundtripper.go 87.92% <ø> (ø)
pkg/internal/testutil/verifier.go 96.49% <ø> (ø)
pkg/retriever/assignablecandidatefinder.go 100.00% <ø> (ø)
pkg/retriever/bitswapretriever.go 95.83% <ø> (ø)
pkg/retriever/graphsyncretriever.go 85.62% <ø> (ø)
pkg/retriever/httpretriever.go 86.82% <ø> (ø)
pkg/retriever/parallelpeerretriever.go 90.80% <ø> (ø)
... and 2 more

... and 6 files with indirect coverage changes

@rvagg rvagg merged commit 48f2ae7 into main Dec 19, 2024
9 checks passed
@rvagg rvagg deleted the rvagg/deps branch December 19, 2024 01:18
@rvagg
Copy link
Member Author

rvagg commented Dec 19, 2024

for the record, bitswap is now failing again with this switch back to the main implementation https://github.com/filecoin-project/lassie/actions/runs/12404375770/job/34629434305?pr=497

but I'm deciding to not care about this because it's too hard to maintain a bitswap fork; if people encounter this problem IRL and actually notice it, take it up with boxo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants