Apply suggestions from code review

Co-authored-by: Rod Vagg <[email protected]>
filecoin-project · May 1, 2024 · af4c2cd · af4c2cd
1 parent 9265211
commit af4c2cd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/chain/types/ethtypes/eth_1559_transactions.go b/chain/types/ethtypes/eth_1559_transactions.go
@@ -262,7 +262,7 @@ func (tx *Eth1559TxArgs) packTxFields() ([]interface{}, error) {
 
 func parseEip1559Tx(data []byte) (*Eth1559TxArgs, error) {
 	if data[0] != Eip1559TxType {
-		return nil, xerrors.Errorf("not an EIP-1559 transaction: first byte is not 2")
+		return nil, xerrors.Errorf(fmt.Sprintf("not an EIP-1559 transaction: first byte is not %d", Eip1559TxType))
 	}
 
 	d, err := DecodeRLP(data[1:])

diff --git a/chain/types/ethtypes/eth_transactions.go b/chain/types/ethtypes/eth_transactions.go
@@ -22,10 +22,10 @@ import (
 const (
 	// LegacyHomesteadEthTxSignaturePrefix defines the prefix byte used to identify the signature of a legacy Homestead Ethereum transaction.
 	LegacyHomesteadEthTxSignaturePrefix = 0x01
-	Eip1559TxType                       = 0x2
+	Eip1559TxType                       = 0x02
 
-	ethLegacyHomesteadTxType    = 0x0
-	ethLegacyHomesteadTxChainID = 0x0
+	ethLegacyHomesteadTxType    = 0x00
+	ethLegacyHomesteadTxChainID = 0x00
 )
 
 // EthTransaction defines the interface for Ethereum-like transactions.