Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: PR template: only allow PR to be merged if its all green #10975

Closed
wants to merge 4 commits into from
Closed

chore: PR template: only allow PR to be merged if its all green #10975

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
11bff15
only allow PR to be merged if its all green
jennijuju Jun 13, 2023
e48f27a
Update .github/pull_request_template.md
jennijuju May 28, 2024
c553aa1
Update pull_request_template.md
jennijuju May 28, 2024
0a23a4a
Merge branch 'master' into jennijuju-patch-4
jennijuju May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,21 @@
## Related Issues
<!-- Link issues that this PR might resolve/fix. If an issue doesn't exist, include a brief motivation for the change being made -->
## Related Issues & Context
<!-- Link issues that this PR might resolve/fix. If an issue doesn't exist, including the context for the change being made -->

## Proposed Changes
<!-- A clear list of the changes being made -->

## Additional Info
<!-- Callouts, links to documentation, and etc -->
## Test Plan
<!-- PRs should include unit/integration tests, and/or IRL operational testing plans-->

## Checklist

Before you mark the PR ready for review, please make sure that:
@lotus-maintainers will only approve the PR if all boxes below are checked:

- [ ] Commits have a clear commit message.
- [ ] PR title is in the form of of `<PR type>: <area>: <change being made>`
- example: ` fix: mempool: Introduce a cache for valid signatures`
- `PR type`: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
- `area`, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
- [ ] If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
- [ ] New features have usage guidelines and / or documentation updates in
- [ ] [Lotus Documentation](https://lotus.filecoin.io)
- [ ] [Discussion Tutorials](https://github.com/filecoin-project/lotus/discussions/categories/tutorials)
- [ ] Tests exist for new functionality or change in behavior
- [ ] CI is green
Loading