Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend datacap expiration #11466

Closed
wants to merge 1 commit into from

Conversation

swift-mx
Copy link
Contributor

@swift-mx swift-mx requested a review from a team as a code owner November 29, 2023 10:02
@swift-mx swift-mx requested review from snadrus and mb1896 November 29, 2023 10:02
@magik6k magik6k self-requested a review November 29, 2023 12:21
Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swift-mx Can we please increase the scope of this PR to cover all cases of the claim extension?

  1. Extend all claims for a miner ID

  2. Extend all claims for multiple miner IDs

  3. Extend specified claims for a miner ID

  4. Extend specific claims for specific miner ID

  5. In case, wallet address is different from claim.Client then we should filter out such claims and in the end ask client if they wish to extend such claims as well. Extending such claims require client to send an allocation message and client will end up spending the data cap. This could be a prompt with all the info and final data cap requirements asking client to choose between "Yes" or "No". You can also add a --force flag to skip this check.

TermMax should default to verifregtypes.MaximumVerifiedAllocationTerm if not provided by the user.

We should encourage client to set TermMax to MaximumVerifiedAllocationTerm. A client has already spent the datacap. I don't see a lot of reasons (apart from client internal policies) to not use the maximum allowed. It costs nothing to client and SPs get 10x power till TermMax. It also saves gas as we will sending just 1 message.

Apart from this, we should also align to use terminology defined in Actors.

The expiration-cutoff also doesn't seem very logical. What scenarios would require me to extend my claims on periodic basis. It seems like a waste of gas.

@LexLuthr
Copy link
Contributor

LexLuthr commented Mar 8, 2024

Please note that we have one more PR to implement claim extension #11545

I would request you and @nicelove666 to work together to avoid duplicating efforts and expanding the scope of the command as requested.

@beck-8
Copy link
Contributor

beck-8 commented Mar 12, 2024

#10001

@LexLuthr
Copy link
Contributor

Closing this there has been no input from author. #11711 supersedes this now.

@LexLuthr LexLuthr closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants