chore: ffi: copy verifier iface, mock & ffi out of storage #11581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
force-pushed
the
rvagg/non-storage-verifier
branch
3 times, most recently
from
cdb93cd to
6a48939
Compare
|
Deleted a couple of comments in this thread as I was trying to figure out why some itests weren't passing - it ended up being a misunderstanding of how we use fx to do interface matching so I wasn't getting the mock verifier in place for those test. Resolved now and all passing. |
|
Renamed the package to |
rvagg
force-pushed
the
rvagg/non-storage-verifier
branch
2 times, most recently
from
2e13513 to
56762ef
Compare
rvagg
force-pushed
the
rvagg/non-storage-verifier
branch
from
56762ef to
ba0c691
Compare
rvagg
force-pushed
the
rvagg/non-storage-verifier
branch
2 times, most recently
from
8a2b5a6 to
4cc7061
Compare
rvagg
force-pushed
the
rvagg/non-storage-verifier
branch
from
4cc7061 to
f3019f3
Compare
one step toward a cleaner separation of miner & chain
rvagg
force-pushed
the
rvagg/non-storage-verifier
branch
from
f3019f3 to
b56788f
Compare
rvagg
changed the title
rvagg
commented
Aug 8, 2024
rvagg
commented
Aug 8, 2024
rvagg
commented
Aug 8, 2024
masih
approved these changes
Aug 8, 2024
rjan90
pushed a commit
to hanabi1224/lotus
that referenced
this pull request
Aug 12, 2024
…project#11581) * chore: copy verifier iface, mock & ffi out of storage one step toward a cleaner separation of miner & chain * ffi: s/verifier/proofs, incorporate GenerateUnsealedCID * fix: ffi: use non-ffi version of GenerateUnsealedCID * doc: proofs: document GenerateUnsealedCID use
rjan90
pushed a commit
that referenced
this pull request
Aug 12, 2024
* chore: copy verifier iface, mock & ffi out of storage one step toward a cleaner separation of miner & chain * ffi: s/verifier/proofs, incorporate GenerateUnsealedCID * fix: ffi: use non-ffi version of GenerateUnsealedCID * doc: proofs: document GenerateUnsealedCID use
ribasushi
pushed a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this pull request
Aug 20, 2024
…project#11581) * chore: copy verifier iface, mock & ffi out of storage one step toward a cleaner separation of miner & chain * ffi: s/verifier/proofs, incorporate GenerateUnsealedCID * fix: ffi: use non-ffi version of GenerateUnsealedCID * doc: proofs: document GenerateUnsealedCID use
ribasushi
pushed a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this pull request
Aug 20, 2024
…project#11581) * chore: copy verifier iface, mock & ffi out of storage one step toward a cleaner separation of miner & chain * ffi: s/verifier/proofs, incorporate GenerateUnsealedCID * fix: ffi: use non-ffi version of GenerateUnsealedCID * doc: proofs: document GenerateUnsealedCID use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking for some feedback on this as a step in further separating miner and chain code. Aside from itests (where everything is very entangled), the verifier is the second most entangled component since it sits within the storage/ffiwrapper package. Just by pulling it out of there it significantly reduces the amount of non-miner code that reaches into storage/ for anything; the only things left are minor and mostly single-use.
This change is mainly duplication, but very targeted, only the verifier comes out of storage/ffiwrapper.