ci: ci: create gh workflow that runs go checks #11761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Mar 21, 2024
LexLuthr
pushed a commit
that referenced
this pull request
Mar 26, 2024
* ci: create gh action that installs go from go.mod * ci: create gh action that installs ubuntu dependencies * ci: create gh workflow that runs go checks * ci: test the check workflow * Revert "ci: test the check workflow" This reverts commit 1d0759d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#11734
Proposed Changes
This PR creates a new GitHub Actions workflow (
check.yml) that performs the following jobs previously handled exclusively by CircleCI:Additional Info
You can find an example run of the workflow at: https://github.com/filecoin-project/lotus/actions/runs/8362592926
Unlike the CircleCI check jobs, the ones from the newly added workflow do not have to wait for the build (
make lotus deps) to finish. Instead, the check jobs callmake lotusandmake depsas needed. This results in some work duplication but reduces the overall workflow runtime by ~3 minutes.We did not use a configuration matrix in the newly added workflow because, in our opinion, separate jobs provide better clarity here. It wouldn't be a mistake to opt in for the matrix approach, though.
The newly added makes use of 2 helper actions:
ocl-icd-opencl-dev libhwloc-dev pkg-configon the runnergoon the runner (it uses the version it finds in the go.mod file)The newly added workflow is intended to run alongside its' CircleCI counterpart for 1-2 weeks. After that period, we want to evaluate its' success rate and execution time. Based on this information, we'll either remove the applicable CircleCI jobs or apply necessary fixes to the new workflow and repeat the evaluation.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps