Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: curio: Storage reservations when fetching #11774

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 22, 2024

Related Issues

On top of #11730 because that PR has related fixes needed for this PR to work.

This PR fixes failing test-itest-path_type_filters on master

Proposed Changes

  • Make it possible to tell the sector starage system which paths sector data should be fetched to if fetching is needed
  • Make reservations not double-count storage when requested with existing data
  • Propagate Curio reservations to sector storage
  • Enable storage reservations on SDRTrees
  • Enable storage reservations on MoveStorage Touches more code, can be a separate PR.

Additional Info

TODO:

  • Complete changes
  • Test on mainnet

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

curiosrc/ffi/task_storage.go Outdated Show resolved Hide resolved
Base automatically changed from fix/curio-fin-fixes to master March 22, 2024 15:05
@magik6k magik6k force-pushed the feat/curio-consistent-reservations branch from 8d128f0 to d3d6a6d Compare March 24, 2024 16:30
@magik6k magik6k marked this pull request as ready for review March 25, 2024 08:40
curiosrc/seal/task_trees.go Show resolved Hide resolved
@magik6k magik6k merged commit 0213851 into master Mar 26, 2024
98 checks passed
@magik6k magik6k deleted the feat/curio-consistent-reservations branch March 26, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants