Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: curio seal: Check ticket age before sending PreCommit message #11779

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 25, 2024

Related Issues

Proposed Changes

Mark sectors with expired tickets as failed. The (not yet written) code in the poller will figure out what to do next with the sector (which will probably be "remove it") - which is much better than getting it into an infinite retry loop which will forever fail to send the message with the following error:

2024-03-25T12:16:07.330+0100	ERROR	harmonytask	harmonytask/task_type_handler.go:178	Do() returned error	{"type": "PreCommitSubmit", "id": "934107", "error": "sending message: GasEstimateMessageGas error: message execution failed: exit 16, reason: message failed with backtrace:\n00: f02620 (method 28) -- seal challenge epoch 3748434 too old, must be after 3764852 (16)\n (RetCode=16)", "errorVerbose": "sending message:\n    github.com/filecoin-project/lotus/curiosrc/seal.(*SubmitPrecommitTask).Do\n        /home/magik6k/github.com/filecoin-project/go-lotus/curiosrc/seal/task_submit_precommit.go:194\n  - GasEstimateMessageGas error:\n    github.com/filecoin-project/lotus/curiosrc/message.(*Sender).Send\n        /home/magik6k/github.com/filecoin-project/go-lotus/curiosrc/message/sender.go:305\n  - message execution failed: exit 16, reason: message failed with backtrace:\n00: f02620 (method 28) -- seal challenge epoch 3748434 too old, must be after 3764852 (16)\n (RetCode=16)"}

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k force-pushed the feat/curio-pc-exp-check branch from 3a9a19f to c121707 Compare March 25, 2024 11:21
@magik6k magik6k merged commit ae7829a into master Mar 26, 2024
97 of 98 checks passed
@magik6k magik6k deleted the feat/curio-pc-exp-check branch March 26, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants