-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: curio: allow multiple pieces per sector #11935
Conversation
@snadrus This is WIP, I will be moving everything to DB. |
9238021
to
fe7ab71
Compare
f82bd5c
to
2158613
Compare
Converting back to draft as I need to add new tables to avoid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an absolutely amazing chunk of work!
Some easy to address comments, but nothing fundamentally wrong. My main concert is around how we assign pieces to sectors - where we should be taking TermMin/Max bounds of the piece we're inserting vs expirations of pieces already assigned to a given sector (also possible that I've missed this bit of logic, this PR is big).
In lotus-miner this is done in - https://github.com/filecoin-project/lotus/blob/master/storage/pipeline/sealing.go#L155
All checks have passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, as much as it is possible to review PRs this big.
We'll probably find some issues here when we start running this code, so the sooner we do that the better.
Related Issues
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps