Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: itest: fix wdpost proving epoch calculation #12113

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jun 19, 2024

Fixes: #12091 (I think)

Pulled out of #12105 where I was forced to figure it out and fix it.

@rvagg rvagg requested a review from aarshkshah1992 June 19, 2024 06:37
Copy link

github-actions bot commented Jun 19, 2024

All checks have passed

@rvagg rvagg force-pushed the rvagg/wdpost-fix branch from 09ff6eb to 43fc0a9 Compare June 19, 2024 07:01
@rvagg
Copy link
Member Author

rvagg commented Jun 19, 2024

I changed this to wait one challenge window and re-collect deadline Info because I'm seeing odd behaviour locally with 47 and am wondering if there's a special case there

@rvagg rvagg force-pushed the rvagg/wdpost-fix branch from 43fc0a9 to 9716b2b Compare June 19, 2024 07:04
@rvagg rvagg marked this pull request as draft June 19, 2024 07:15
@rvagg rvagg force-pushed the rvagg/wdpost-fix branch 2 times, most recently from 8b432d3 to 71f8da2 Compare June 19, 2024 07:21
@rvagg rvagg force-pushed the rvagg/wdpost-fix branch from 71f8da2 to fccf4b4 Compare June 19, 2024 08:51
@rvagg rvagg marked this pull request as ready for review June 19, 2024 08:51
@rvagg
Copy link
Member Author

rvagg commented Jun 19, 2024

I have a bit more confidence in this one after tinkering a bit more and grokking actors a bit better. One thing I'm doing now is not hitting the deadline open exactly, but waiting a bit, because I think we might be getting in too quick before cron updates the deadline index in state. It doesn't explain the 47/0 failures specifically but we'll see if that comes back after this. I'll pull it back in to #12105 and continue with this.

Copy link
Collaborator

@ribasushi ribasushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fwiw I ran a number of itest runs since I included this and have not seen the issue crop up again

:shipit:

@rvagg
Copy link
Member Author

rvagg commented Jun 19, 2024

ironically the test failed in CI for this branch, but it's different I think, might just be a timeout https://github.com/filecoin-project/lotus/actions/runs/9579047475/job/26410654516?pr=12113

@rvagg rvagg force-pushed the rvagg/wdpost-fix branch from bf01ba3 to ee14e05 Compare June 19, 2024 22:28
@rvagg rvagg force-pushed the rvagg/wdpost-fix branch from ee14e05 to 013d064 Compare June 19, 2024 22:33
@rvagg
Copy link
Member Author

rvagg commented Jun 20, 2024

been re-running in CI and it seems solid; will continue to test in my niporep branch but I think this is good to go

@rvagg rvagg enabled auto-merge (rebase) June 21, 2024 03:30
@rvagg rvagg merged commit 8f3c54f into master Jun 21, 2024
77 checks passed
@rvagg rvagg deleted the rvagg/wdpost-fix branch June 21, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky TestManualSectorOnboarding - post sector in wrong deadline
3 participants