Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: f3: Upgrade go mod F3 dependency to v0.0.3 tagged release #12216

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

masih
Copy link
Member

@masih masih commented Jul 11, 2024

Related Issues

N/A

Proposed Changes

Use concrete/latest version of F3: v0.0.3

Additional Info

None.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • Update CHANGELOG.md or signal that this change does not need it.
    • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
    • If the change does not require a CHANGELOG.md entry, do one of the following:
      • Add [skip changelog] to the PR title
      • Add the label skip/changelog to the PR
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@masih masih requested review from Stebalien and Kubuxu July 11, 2024 16:15
@masih masih added the skip/changelog This change does not require CHANGELOG.md update label Jul 11, 2024
@masih masih force-pushed the masih/dep-up-f3-0-0-3 branch from 0d32d25 to 3b50e3d Compare July 12, 2024 10:36
@Kubuxu Kubuxu force-pushed the masih/dep-up-f3-0-0-3 branch 2 times, most recently from 5ceba75 to 3b50e3d Compare July 12, 2024 10:42
@Kubuxu
Copy link
Contributor

Kubuxu commented Jul 12, 2024

@masih sorry for the mess, I decided to fix it right the same moment you did. I pushed your commit back.

@masih masih removed the skip/changelog This change does not require CHANGELOG.md update label Jul 12, 2024
Use concrete/latest version of F3: v0.0.3
@masih masih force-pushed the masih/dep-up-f3-0-0-3 branch from 3b50e3d to fb7a3ae Compare July 12, 2024 10:48
@masih
Copy link
Member Author

masih commented Jul 12, 2024

@masih sorry for the mess, I decided to fix it right the same moment you did. I pushed your commit back.

No worries; thanks Kuba!

@masih masih merged commit ca1d963 into master Jul 12, 2024
80 checks passed
@masih masih deleted the masih/dep-up-f3-0-0-3 branch July 12, 2024 12:12
@rjan90
Copy link
Contributor

rjan90 commented Jul 16, 2024

Removing the release/backport label from this PR, as it is obsoleted by this PR: #12237 which also carries the release/backport label

@ribasushi
Copy link
Collaborator

@rjan90 note (I missed this earlier) this PR contains an actual code change so you actually need to backport this together with the subsequent one 😅

@Kubuxu
Copy link
Contributor

Kubuxu commented Jul 16, 2024

@rjan90 feel free to apply this code change manually as it is quite minimal

@rjan90 rjan90 mentioned this pull request Jul 22, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants