test: events: test sqlite indexes used in query plan of all selects and updates #12267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigLep
reviewed
Jul 19, 2024
rvagg
force-pushed
the
rvagg/query-plan-check
branch
from
354377c to
5c7ef31
Compare
rvagg
force-pushed
the
rvagg/query-plan-check
branch
from
5c7ef31 to
d2f6776
Compare
rvagg
force-pushed
the
rvagg/events-db-perf
branch
from
40aa442 to
7d9e21e
Compare
rvagg
force-pushed
the
rvagg/query-plan-check
branch
from
d2f6776 to
1b06f5e
Compare
aarshkshah1992
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stacked PR ontop of #12261; I'm doing it separately because it moves a bunch of things around that are a bit of a distraction in #12261 and I think it's probably easier to see and review as a separate commit.
This is all about running
EXPLAIN QUERY PLANon all selects and updates in the events db and ensuring that an acceptable index is used as the first step in the execution. We want to either narrow down by height or tipset and we have a few indexes that do this across two tables.This should lock in the perf gains in #12261 such that any future tinkering with the indexes will fail this test and cause the author to consider carefully whether the change is appropriate.