Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lotus-miner: batch expired sector removal in lotus-miner #12268

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

LexLuthr
Copy link
Contributor

@LexLuthr LexLuthr commented Jul 19, 2024

Related Issues

Proposed Changes

Currently, all sectors are removed in a for loop if expired sectors are marked for removal. This PR, creates a batch of 5 sectors and waits 2 seconds between batched. It should help alleviate the pressure on storage subsystem and avoid crashes.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • Update CHANGELOG.md or signal that this change does not need it.
    • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
    • If the change does not require a CHANGELOG.md entry, do one of the following:
      • Add [skip changelog] to the PR title
      • Add the label skip/changelog to the PR
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@LexLuthr LexLuthr changed the title fix: batch expired sector removal in lotus-miner fix: lotus-miner: batch expired sector removal in lotus-miner Jul 19, 2024
@LexLuthr LexLuthr added the skip/changelog This change does not require CHANGELOG.md update label Jul 19, 2024
@LexLuthr LexLuthr requested a review from magik6k July 19, 2024 10:52
@magik6k magik6k merged commit 2ea1009 into master Jul 22, 2024
81 of 84 checks passed
@magik6k magik6k deleted the fix/sector-remote branch July 22, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants