[skip changelog] chore: logging: switch runtime Print() spots to use the logger

[ribasushi]

Proposed Changes

While examining a fullsync log noticed that the actor bundle loader prints directly to STDOUT. Grepping briefly through the codebase uncovered only 2 spots like that, so fix them both.

[ribasushi]

cc @rvagg for this one I suppose

[rvagg]

You've made this more controversial than it should be and playing divide and conquer among maintainers is not appreciated.

Please revert the changes entirely in chain/consensus/filcns/upgrades.go and if you really feel strongly enough to bikeshed about a stdout print that's already gated by a tty check then feel free to open a separate PR.

The other change is reasonable.

[rvagg]

remove chain/consensus/filcns/upgrades.go changes

[ribasushi]

playing divide and conquer among maintainers is not appreciated.

@rvagg: I hear what you are saying and I call bullshit.

1. Straightforward, single-commit PR is open during the weekend
2. You are highlighted to review due to your involvement in chore: ui: add a terminal check #12256 (review)
3. You request some changes, which I begrudgingly implement without saying anything
4. @masih and @ZenGround0 step in and say "this is not cool, do the old thing"
5. I do the old thing, now 2 days later, and am asking y'all as employees of FilOz and holders of all the keys to get your shit together
6. You write the thing I quoted above

I do not need to tell you how this looks from the outside, for a supposedly-open project to "accept" free, obviously correct contributions like this.

Your mandate is to be stewards, not gatekeepers. Saying "thank you" to contributions is optional. Removing obstructions is not.

in closing: the splash-to-stdout-instead-of-logging-system is still a problem. I am not fixing this one as per request. I hope one of @rvagg @masih @ZenGround0 will.

[rvagg]

@masih and @ZenGround0 step in and say "this is not cool, do the old thing"

As per @masih:

FWIW, I would vote for removing the cosmetic splash in favour of consistently logging the system behaviour.

I don't read his text or @ZenGround0's 👍 as a vote for your original change but for removing the splash entirely.

That key misunderstanding - either yours or mine - is why I'm asking this to be scaled back because this is not worth anyone's time doing here, for the sake of a splash, that's gated by a tty check and doesn't touch the logs, yet your change makes 36 lines of ascii art go into everyone's logs: https://github.com/filecoin-project/lotus/blob/4cc7061c8f7084a89062b21eafecffea896b1f34/chain/consensus/filcns/UpgradeSplash.txt